Changeset 1731

Timestamp:

11/04/08 21:11:21 (2 months ago)

Author:

Chuck.Esterbrook

Message:

Code cleanup.

Location:

cobra/trunk/Source

Files:

• BinaryOpExpr.cobra (modified) (1 diff)
• CobraParser.cobra (modified) (1 diff)
• Expr.cobra (modified) (4 diffs)
• Members.cobra (modified) (1 diff)

cobra/trunk/Source/BinaryOpExpr.cobra

@@ -590 +590 @@
                         .compiler.curCodeMember.usesBase  # use of base implies override if the containing member is not already marked new
                 else if _left inherits ThisLit
-                        if _left.isVisible
+                        if not _left.isImplicit
                                 .compiler.warning(this, 'An explicit "this" literal is unnecessary for accessing members of the current object. You can remove "this".')
-                        else if .isVisible and .dotRight.name.startsWith('_')
+                        else if not .isImplicit and .dotRight.name.startsWith('_')
                                 .compiler.warning(this, 'An explicit dot (".") is unnecessary for accessing underscored members of the current object. You can remove ".".')
                 if not _type

cobra/trunk/Source/CobraParser.cobra

@@ -2671 +2671 @@
                         finally
                                 .opStack.pop
-                        return BinaryOpExpr.make(token to !, 'DOT', ThisLit(token, isVisible=false), expr)
+                        return BinaryOpExpr.make(token to !, 'DOT', ThisLit(token, isImplicit=true), expr)
                 else if peek=='NIL'
                         return NilLiteral(.grab)

cobra/trunk/Source/Expr.cobra

@@ -48 +48 @@
         var _contextType as IType?
         var _isParened as bool
-        var _isVisible as bool
         var _argumentLabel = ArgumentLabel.None
 
         def init(token as IToken)
                 base.init(token)
-                _isVisible = true
 
         def addRefFields is override
@@ -62 +60 @@
                 """
                 Indicates the label for an argument such as 'out' or 'inout'.
-                """
-
-        pro isVisible from var
-                """
-                Indicates if the expression is visible in the source code.
-                Defaults to true.
-                
-                An expression may not be if it was generated by means other than parsing,
-                usually during _bindImp for the purpose of a _transformTo call.
-                It's not always imperative to set this to false--only in cases where it's needed.
-                Those cases are typically warnings centered around coding style ("favor succinct forms").
                 """
 
@@ -885 +872 @@
                         if _definition
                                 if _definition inherits AbstractMethod or _definition inherits MemberOverload
-                                        _transformTo(DotExpr(.token, 'DOT', ThisLit(.token, isVisible=false), MemberExpr(.token), isVisible=false).bindAll)
+                                        _transformTo(DotExpr(.token, 'DOT', ThisLit(.token, isImplicit=true), MemberExpr(.token), isImplicit=true).bindAll)
                                 else
                                         _type = _definition.typeForIdentifier
@@ -1465 +1452 @@
                                 # _foo(x) --> ._foo(x)
                                 newCall = CallExpr(.token, .name, .args, true)
-                                dotted = DotExpr(.token, 'DOT', ThisLit(.token, isVisible=false), newCall, isVisible=false).bindImp
+                                dotted = DotExpr(.token, 'DOT', ThisLit(.token, isImplicit=true), newCall, isImplicit=true).bindImp
                                 _type = dotted.type to IType
                                 _transformTo(dotted)

cobra/trunk/Source/Members.cobra

@@ -828 +828 @@
                                                                 expr = IdentifierExpr(token, decl) to Expr
                                                         else
-                                                                expr = DotExpr(token, 'DOT', ThisLit(token, isVisible=false), MemberExpr(token, decl.name), isVisible=false) to Expr
+                                                                expr = DotExpr(token, 'DOT', ThisLit(token, isImplicit=true), MemberExpr(token, decl.name), isImplicit=true) to Expr
                                                         stmts.add(AssertStmt(token, IsNotNilExpr(token, expr), nil))
                                 if stmts.count