Changeset 1740

Timestamp:

11/07/08 16:16:30 (2 months ago)

Author:

Chuck.Esterbrook

Message:

Fixed: Errors about unknown properties in Foo(a=1, b=2) give the wrong line number.

Location:

cobra/trunk

Files:

• Source/Expr.cobra (modified) (2 diffs)
• Tests/120-classes/322-construct-prop-set-error.cobra (added)

cobra/trunk/Source/Expr.cobra

@@ -679 +679 @@
                                 else
                                         .throwError('Argument [i+1] of method "[_name]" expects type [param.type.name], but the call is supplying type [arg.type.name].')
-        # end of _bindImp helpers
                 
         def toCobraSource as String is override
@@ -1510 +1509 @@
                                         if not arg.left inherits IdentifierExpr
                                                 .recordError('General purpose assignments are not allowed as arguments. Assignment syntax can only be used for keyword arguments.')
-                                        # TODO: check property name
+                                        if not expr.receiverType.isDynamicOrPassThrough
+                                                propertyName = (arg.left to IdentifierExpr).name
+                                                if expr.memberForName(propertyName) is nil
+                                                        suggs = .expr.suggestionsForBadMemberName(propertyName)
+                                                        isBoxAccess = expr inherits IdentifierExpr and (expr to IdentifierExpr).definition inherits Box  # like "Console.writeLine" where the receiver is a literal class or struct reference
+                                                        whoseTypeIs = if(isBoxAccess, '', ' whose type is "[expr.receiverType.name]"')
+                                                        .recordError('Cannot find a definition for "[propertyName]" in "[expr.toCobraSource]"[whoseTypeIs].[_suggestionsMessage(suggs)]')
                                         arg.right.bindImp  # 'x=y' has special treatment in arguments
                                 else