Changeset 1912

Timestamp:

01/17/09 22:55:30 (3 years ago)

Author:

Chuck.Esterbrook

Message:

Fixed: Passing a method reference as a named property to an initalizer causes a false compilation error.
reported-by:jonathandavid

Location:

cobra/trunk

Files:

• Developer/IntermediateReleaseNotes.text (modified) (1 diff)
• Source/Expr.cobra (modified) (1 diff)
• Tests/120-classes/320-construct-prop-set.cobra (modified) (2 diffs)

cobra/trunk/Developer/IntermediateReleaseNotes.text

@@ -310 +310 @@
 
 * Fixed: The compile does not correctly read nilable types from libraries, resulting in false compilation errors. ticket:136
+
+* Fixed: Passing a method reference as a named property to an initalizer causes a false compilation error.

cobra/trunk/Source/Expr.cobra

@@ -1706 +1706 @@
                 propsToSet.add(arg)
                 if firstPropArg == -1, firstPropArg = i
+                propertyName = (arg.left to IdentifierExpr).name
+                argType = _expr.memberForName(propertyName).resultType
                 arg = arg.right
             else
                 argsForInitCall.add(if(arg inherits NilLiteral, arg, IdentifierExpr(token.copy('ID', 'arg[i]'))))
-            paramsForDecl.add(Param(box.token.copy('ID', 'arg[i]'), arg.type))
+                argType = arg.type to !
+            paramsForDecl.add(Param(box.token.copy('ID', 'arg[i]'), argType))
             i += 1
         name = '_ch_ext_init_[.serialNum]'  # ch = class helper, ext = extended, init = initializer

cobra/trunk/Tests/120-classes/320-construct-prop-set.cobra

@@ -1 +1 @@
 class X
 
-    def main is shared
-        s = Stuff(a=1, b=2)
-        assert s.a == 1
-        assert s.b == 2
+    shared
+    
+        var _counter = 0
+        
+        get counter from var
+    
+        def incCounter
+            _counter += 1
 
-        s = Stuff('a', b='b')
-        assert s.a == 'a'
-        assert s.b == 'b'
-
-        letters = 'aoeu'
-        s = Stuff(letters, b='b')
-        assert s.a == letters
-        assert s.b == 'b'
-
-        s = Stuff(nil, b='b')
-        assert s.a is nil
-        assert s.b == 'b'
-
-        t = Thing(nil, data=5)  # test passing nil to a strongly typed arg
-        assert t.data == 5
-
-        s = Stuff(style=StyleType(Hype))  # test enum construction nested inside a prop set
+        def main
+            s = Stuff(a=1, b=2)
+            assert s.a == 1
+            assert s.b == 2
+    
+            s = Stuff('a', b='b')
+            assert s.a == 'a'
+            assert s.b == 'b'
+    
+            letters = 'aoeu'
+            s = Stuff(letters, b='b')
+            assert s.a == letters
+            assert s.b == 'b'
+    
+            s = Stuff(nil, b='b')
+            assert s.a is nil
+            assert s.b == 'b'
+    
+            s = Stuff(doSomething = ref .incCounter)  # pass a method reference
+            assert .counter == 0
+            ds = s.doSomething
+            ds()
+            assert .counter == 1
+            
+            t = Thing(nil, data=5)  # test passing nil to a strongly typed arg
+            assert t.data == 5
+    
+            s = Stuff(style=StyleType(Hype))  # test enum construction nested inside a prop set
 
 
@@ -50 +65 @@
 
 
+    sig DoSomethingSig
+
+    pro doSomething from var as DoSomethingSig?
+
+
 class Thing