Changeset 2287

Timestamp:

02/14/10 07:21:12 (2 years ago)

Author:

Chuck.Esterbrook

Message:

Improved error recovery. Avoid an uncaught exception in the compiler.
Unfortunately, I do not have a new (self contained, small) test case for this.
Existing test cases pass.

Files:

• cobra/trunk/Source/Expr.cobra (modified) (5 diffs)

cobra/trunk/Source/Expr.cobra

@@ -566 +566 @@
                 return
 
-        _bindImpArgs
+        hasErrors = _bindImpArgs
         definition as IMember?
         type as IType?
@@ -588 +588 @@
                 # there is a FallThroughException down below that would report this if it happened
                 if definition inherits BoxMember
-                    if not .hasError
+                    if not .hasError and not hasErrors
                         args = _args
                         if definition inherits MemberOverload
@@ -595 +595 @@
                             # http://www.google.com/search?hl=en&q=C%23+overloaded+method+resolution
                             # TODO: handle type inference for generic members. See the C# spec for details.
-                        
                             winner = definition.computeBestOverload(.args, .genericArgTypes, true)
                             sharp'definition = winner'
@@ -692 +691 @@
         transformTarget._transformTo(postCall)
 
-    def _bindImpArgs
+    def _bindImpArgs as bool
+        hasErrors = false
         num = 1
         for arg in List<of Expr>(_args)
@@ -706 +706 @@
                 ne.prefixMessage('For "[_name]" arg [num]: ')
                 .compiler.recordError(ne)
+                hasErrors = true
             num += 1
+        return hasErrors
 
     def _didVariArgs(definition as BoxMember) as bool