These are really annoying when scanning for errors from additions
It'd be nice if they werent there
CobraParser.cobra(1090): warning: The value of variable "attribs" is never used.
this is true ( presumably for the moment).
if these are placeholders for something in the future could we comment them out until the future something comes along and put a trailing note on them
if not can we remove (both) lines entirely?
The second is spurious
Boxes.cobra(853): warning: The expression "_needs_typeArgs" (of type "List<of IType>") will always evaluate to true because it is not nilable. You can remove the expression or check for non-empty collections with ".count".
The surrounding lines look like this
- Code: Select all
var _needs_typeArgs as List<of IType>?
"""
When non-nil, this box is constructed from a generic *and* requires completion of its construction of members.
"""
def completeMemberConstructionIfNeeded
if _needs_typeArgs
assert not .isGenericDef
if not .didBindInt and not .isBindingInt
.bindInt # this is required when inheriting from a constructed type such as "class Foo inherits List<of int>". Since "bind inheritance" happens prior to "bind interface", the base type will have been partially constructed without ever binding int.
if _needs_typeArgs
_completeConstruction(_needs_typeArgs)
_needs_typeArgs = nil
Line 853 is the second 'if _needs_typeArgs' statement. (whoa!)
This warning is spurious since _needs_typeArgs is clearly marked as nilable (List<of IType>?) AND its not complaining about the first
if _needs_typeArgs line (exactly the same).
