Ticket #100: final.patch

Source/BackEndClr/SharpGenerator.cobra

@@ -536 +536 @@
             # only have to specify the ones that are different
             'shared': 'static',
             'nonvirtual': '',
+            'final': '',  # c# readonly only on fields, 'sealed' on classes (?)
         }
         sep = ''
         for name in isNames
@@ -1447 +1448 @@
             # only have to specify the ones that are different
             'shared': 'static',
             'nonvirtual': '',
+            'final': 'readonly',
         }
         wroteNames = Set<of String>()
         sep = ''

Source/CobraParser.cobra

@@ -596 +596 @@
         Used by: classDecl, interfaceDecl, enumDecl, indentIsDeclNames
         """
         if _validIsNames is nil
-            _validIsNames = ['fake', 'extern', 'shared', 'virtual', 'nonvirtual', 'override', 'new', 'public', 'protected', 'private', 'internal', 'abstract', 'partial']
+            _validIsNames = ['fake', 'extern', 
+                'shared', 
+                'virtual', 'nonvirtual', 
+                'override', 'new', 
+                'public', 'protected', 'private', 'internal', 
+                'abstract', 
+                'partial', 'final']
         names = List<of String>(_isNamesStack)
         if .optional('IS') is nil
             return names
@@ -608 +614 @@
                     what = 'extern'
                 names.add(what)
             else
-                .throwError('Not expecting "[what]".')
+                if what == 'readonly'
+                    _warning(.last, 'Cobra uses "final" for a runtime initialised constant not "readonly"')
+                    names.add('final')
+                else    
+                    .throwError('Not expecting "[what]".')
             if not .optional('COMMA')
                 if .peek.text in _validIsNames
                     .throwError(.peek, 'Multiple access modifiers should be separated by commas such as "[what], [.peek.text]".')

Tests/820-errors/400-declarations/510-final.cobra

@@ +1 @@
+# Test final - runtime init constant (C# readonly)
+class Final
+    var _year as int is final
+
+    def init(year as int)
+        _year = year
+        
+    def main is shared
+        x = Final(1959)
+        x._year = 1967 # .error. cannot be assigned to
+        

Tests/120-classes/222-fields-final.cobra

@@ +1 @@
+# Test final - runtime initialized constant (C# readonly)
+class Final
+    var _year as int is final
+    var _nyear is final
+
+    def init(year as int)
+        _year = year
+        _nyear = year +1
+        
+    def main is shared
+        x = Final(1959)
+        
+        assert x._year == 1959
+        assert x._nyear == 1960

Tests/800-warnings/500-final.cobra

@@ +1 @@
+class Final
+    var _year as int is readonly  # .warning. Cobra uses "final" for a runtime initialised constant not "readonly"
+    
+    def main is shared
+        pass