Ticket #133: numericFor-opt.patch

Source/BackEndClr/SharpGenerator.cobra

@@ -2540 +2540 @@
             .stop.writeSharpDef(sw)
             sw.write(';\n')
 
+        isSimpleStep = false
         if .step is nil
             sharpStep = '1'
+            isSimpleStep = true
         else if .step inherits IntegerLit
             sharpStep = (.step to IntegerLit).asSharp
+            isSimpleStep = (.step to IntegerLit).value > 0
         else
             sw.write('[sharpType] [sharpStep] = ')
             .step.writeSharpDef(sw)
             sw.write(';\n')
 
-        sw.write('int [sharpDir] = [sharpStep] < 0 ? -1 : +1;\n')
+        if not isSimpleStep
+            sw.write('int [sharpDir] = [sharpStep] < 0 ? -1 : +1;\n')
 
         sw.write('for(')
         if trackLocals
             sw.write('CobraLangInternal.CobraImp.SetLocal("[.var.name]", [sharpVar] = [sharpStart])')
         else
             sw.write('[sharpVar] = [sharpStart]')       
-        sw.write('; ([sharpDir]==1) ? [sharpVar] < [sharpStop] : [sharpVar] > [sharpStop]; ')
+        if isSimpleStep
+            sw.write('; [sharpVar] < [sharpStop] ; ')
+        else
+            sw.write('; ([sharpDir]==1) ? [sharpVar] < [sharpStop] : [sharpVar] > [sharpStop]; ')
         if trackLocals
             sw.write('CobraLangInternal.CobraImp.SetLocal("[.var.name]", [sharpVar] += [sharpStep])')
         else

Developer/IntermediateReleaseNotes.text

@@ -299 +299 @@
 * Fixed: Cobra finds the definitions of identifiers in the parent namespaces of `used` namespaces, even when those parents themselves are not `used`. This leads to complications in practice when many namespaces are being used. ticket:128
 
 * Fixed: Literals outside type range give internal error message. ticket:131
+
+* Optimization: make new numeric For loop as fast as Old Numeric For Loop : ticket:133