Ticket #147: embed-spaces-cmdline.patch

Source/Compiler.cobra

@@ -560 +560 @@
 
         if argList and argList.count 
             args = p.startInfo.arguments ? '' 
-            args += Utils.join(' ', argList) 
-            p.startInfo.arguments = args                
+            hasSpaces = any for a in argList where ' ' in a
+            if hasSpaces 
+                modArgList = List<of String>()
+                for a in argList
+                    newArg = if(' ' in a, '"[a]"', a)
+                    modArgList.add(newArg)
+                args += Utils.join(' ', modArgList) 
+            else
+                args += Utils.join(' ', argList) 
+            p.startInfo.arguments = args 
         return p
 
     ##

Tests/700-command-line/700-run-args.cobra

@@ -13 +13 @@
         .verify(cobraPath, '[echo] -- argA argB argC', 'argA argB argC')
         .verify(cobraPath, '[echo] -run-args x1arg1 x1argB x1argC', 'x1arg1 x1argB x1argC')
         .verify(cobraPath, '-r [echo] -run-args x2arg1 x2argB x2argC', 'x2arg1 x2argB x2argC')
+        .verify(cobraPath, '[echo] -- "argA argB argC"', 'argA argB argC :1')
+        # below exercises broken windows process quoting with ''
+        #.verify(cobraPath, "[echo] -- 'argA1 argB1 argC1'", 'argA1 argB1 argC1 :1')
     
     def verify(cobraPath as String, cmdln as String, expectedText as String)is shared
         p as System.Diagnostics.Process? 

Tests/700-command-line/702-echo.cobra

@@ -6 +6 @@
         for a in args[1:]
             print '[sep][a]' stop
             sep = ' '
+        if args.count >1
+            print ' :[args.count-1]' stop   
         print

Developer/IntermediateReleaseNotes.text

@@ -324 +324 @@
 * Fixed: An unterminated doc string gives an internal error instead of a friendly error message.
 
 * Fixed: Using a type from a binary library with internal methods referring to internal types caused an uncaught exception in the compiler.
+
+* Fixed: String parameters with spaces in commandline.  ticket:147