Ticket #163: infer-matchCollection-item.patch

Source/Boxes.cobra

@@ -526 +526 @@
                 if rt.isDescendantOf(.compiler.dictEnumeratorType)
                     return rt.memberForName('entry').resultType
                 if rt.isDescendantOf(.compiler.enumeratorType)
-                    return rt.memberForName('current').resultType
+                    rtc = rt.memberForName('current').resultType
+                    if rtc.nonNil.name == 'Object'  
+                        # Can we do better with indexer returnType? (e.g MatchCollection)
+                        idxr = .symbolForName(r'[]', true)
+                        if idxr
+                            rti = idxr.resultType
+                            if rti.nonNil.name <> 'Object' 
+                                return rti 
+                    return rtc  
                 else
                     throw FallThroughException({'rt': rt, 'this': this, 'getEnum': getEnum})
         return nil

Tests/300-type-inference/470-from-matchCollection.cobra

@@ +1 @@
+# test fix for Ticket 163 - failure infer returntype of re.matches, items of a MatchCollection
+use System.Text.RegularExpressions
+
+class TestReMatch
+
+    def main is shared
+        str = '@param folly' # some string
+        rePtn = r'^\s*@param\s+(.*)$'
+        m = Regex.match(str, rePtn) 
+        if m.success
+            assert m.captures[0].value == str
+            #print 'Success: capture=[m.groups[1].captures[0]]'
+            assert m.groups[1].captures[0].value == 'folly'
+            
+        str = '@param polly\n@param wally\n@param doodle alladay' # some string
+        
+        expectCaptures = ['polly', 'wally', 'doodle alladay']
+        groupsZero = System.Collections.ArrayList(str.split(c'\n'))
+
+        # This only used to compile if explicitly type var as below
+        #for match as Match in Regex.matches(str, rePtn, RegexOptions.Multiline)
+        
+        for match in Regex.matches(str, rePtn, RegexOptions.Multiline)
+            assert match.groups[1].captures[0].value == expectCaptures[0]
+            gl = [groupsZero[0], expectCaptures[0]]
+            for g in match.groups
+                #print g.value
+                assert g.value == gl[0] # also wuz fail here
+                gl.removeAt(0)
+            groupsZero.removeAt(0)
+            expectCaptures.removeAt(0)

Developer/IntermediateReleaseNotes.text

@@ -455 +455 @@
 * Fixed: Missing error checks for `out` and `inout` being used on an indexer or property.
 
 * Fixed: `someEnum is nil` causes a run-time exception.
+
+* Fixed: Failure to infer types related to System.Text.RegularExpressions (MatchColection and GroupCollections items): ticket 163