Ticket #165: ticket165.patch

Source/Statements.cobra

@@ -509 +509 @@
                 _step.bindImp
             else if _step inherits IntegerLit
                 _dir = if(_step.value < 0, -1, +1)
+        if _checkCompatibleTypes(_start.type to !, _stop.type to !)
+            if _step
+                if not _checkCompatibleTypes(_start.type to !, _step.type to !)
+                    .throwError('For loop start condition type [_start.type.name] is not compatible with step condition type [_step.type.name].')
+                else if not _checkCompatibleTypes(_stop.type to !, _step.type to !)
+                    .throwError('For loop stop condition type [_stop.type.name] is not compatible with step condition type [_step.type.name].')
+        else
+            .throwError('For loop start condition type [_start.type.name] is not compatible with stop condition type [_stop.type.name].')
 
     def inferredType as IType? is override
         return _start.type.greatestCommonDenominatorWith(_stop.type to !)
+    
+    def _checkCompatibleTypes(type1 as IType, type2 as IType) as bool
+        if type1.isDynamic or type2.isDynamic
+            return true
+        else if type1 == type2
+            return true
+        else if type1.isDescendantOf(.compiler.anyIntType) and type2.isDescendantOf(.compiler.anyIntType)
+            return true
+        else
+            return false
 
 
 class ForEnumerableStmt

Tests/110-basics-two/910-bad-numeric-loop-message.cobra

@@ +1 @@
+class X
+    def main
+        j = 4
+        for i in 0 : j/2 # .error. The for loop
+            pass
+        for i in 2 : 10 : 1.5 # .error. The for loop
+            pass
+        for i in 1 : 11.5 : 0.5 # .error. The for loop
+            pass
+        k = 3 to dynamic
+        for i in k : 12 : 1.5 # .error. The for loop
+            pass
+ No newline at end of file