Ticket #169: static-ctor.patch

Source/Members.cobra

@@ -1003 +1003 @@
                 else if stmt.left inherits ThisLit and ((stmt.right inherits MemberExpr and (stmt.right to MemberExpr).name == 'init') or (stmt.right inherits CallExpr and (stmt.right to CallExpr).name == 'init'))  # CC: axe casts
                     isThisInit = true
             if first
-                if .isClassMember and not isBase and not isThisInit
+                if .isClassMember and not isBase and not isThisInit and not stmt inherits PassStmt
                     # structs cannot call base constructors
                     .compiler.warning(stmt, 'The first statement of an "init" cue should be a call to another "init" in this class or the base class.')
             else

Source/BackEndClr/SharpGenerator.cobra

@@ -1697 +1697 @@
 class Initializer
     is partial
 
+    def _fixupIsNames
+        # suppress adding default access modifiers on static initializer
+        # any access modifier in static ctor is error but that should have been caught in bind* methods
+        #   we'll just cater to the default 'public'
+        if 'shared' in _isNames and _isNames.count > 1
+            _isNames.remove('public')
+        
     def innerWriteSharpDef(sw as CurlyWriter)
         base.innerWriteSharpDef(sw)
         .writeSharpAttribs(sw)
@@ -1710 +1717 @@
                         args = firstRight.args
                         Stmt.inInitCall = true
                         didSetInInitCall = true
+        _fixupIsNames
         .writeSharpIsNames(sw)
         sw.write(' [.parentBox.rootName]')
         .writeSharpParams(sw)

Tests/120-classes/325-static-ctor.cobra

@@ +1 @@
+# This gave erroneous codegen on cue init line (ticket:169)
+# generating
+# public static Foo {} <-- 'access modifiers are not allowed on static constructors (C#)'
+class Foo  
+    shared
+        cue init
+            pass
+
+        def x is private
+            pass    
+
+        def main
+            pass    
+            
+        
+class Foo1  
+    cue init is shared
+        pass
+
+    def x is shared, private
+        pass    
+
+    def main1 is shared
+        pass    
+            

Developer/IntermediateReleaseNotes.text

@@ -381 +381 @@
 * Fixed: Cannot pass dynamic values to initializers. ticket:74
 
 * Fixed: Cobra gives an inscrutable error message for numeric for-loops that have incompatible numeric types. ticket:165
+
+* Fixed: Improper codegen for static constructors. ticket:169