Ticket #179: static-class.patch

Source/Members.cobra

@@ -224 +224 @@
     def _bindInt is override
         base._bindInt
         isNames = Set<of String>()
+
+        # Make them explicitly set all members shared on a shared class since while we support shared classes we
+        # dont want to encourage or make use of such classes really easy.
+        #if  .parentBox.typeOf is Class and 'shared' in .parentBox.isNames  and 'shared' not in _isNames
+        #   .compiler.warning(this, 'All members in a shared class must also be shared.')
+        #Implicitly set all members in a shared class to be also shared
+        if  .parentBox.typeOf is Class and 'shared' in .parentBox.isNames 
+            _isNames.add('shared')
+            
         for name in _isNames
             if name in isNames and not .parentBox.isFromBinaryLibrary
                 .compiler.warning(this, 'Duplicate modifier "[name]". You can remove it.')

Source/BackEndClr/SharpGenerator.cobra

@@ -1039 +1039 @@
     get sharpInvariantVisibility as String is abstract
 
     def writeSharpInvariantMethod(sw as CurlyWriter)
-        if .compiler.options['contracts'] <> 'none'
+        if .compiler.options['contracts'] <> 'none' and not 'shared' in _isNames
             sw.write('\nint _ih_invariantGuard;\n\n')
         if .compiler.options['contracts'] <> 'methods'
             return

Tests/120-classes/250-shared-classes/200-static-class-dup.cobra

@@ +1 @@
+class MClass is shared
+    var log = ''    # .warning. Duplicate modifier "shared"
+        is shared
+    
+    cue init is shared  # .warning. Duplicate modifier "shared"
+        .addLog('static initializer called.')   
+        
+    def xx as String is shared # .warning. Duplicate modifier "shared"
+        v ='foo magoo.'
+        .addLog(v) 
+        return v
+
+    def addLog( s as String) is shared # .warning. Duplicate modifier "shared"
+        .log += s 
+        .log += '\n'
+        
+    #get getLog from log is shared  
+    pro getLog as String is shared # .warning. Duplicate modifier "shared"
+        get 
+            return .log
+        
+class EPoint
+    def main is shared
+        assert MClass.xx == 'foo magoo.'
+        assert MClass.getLog.trimEnd.startsWith('static initializer called')
+        assert MClass.getLog.trimEnd.endsWith('foo magoo.')

Tests/120-classes/250-shared-classes/110-static-class-private.cobra

@@ +1 @@
+# shared on class names, implicit shared on all members, implicit private class var
+class MClass is shared
+    var __log = ''
+    
+    cue init
+        .addLog('static initializer called.')   
+        
+    def xx as String
+        v ='foo magoo.'
+        .addLog(v) 
+        return v
+
+    def addLog(s as String)
+        __log += s 
+        __log += '\n'
+        
+    get getLog from __log   # backing variable must be _ prefixed
+    #pro getLog from mlog   # backing variable must be _ prefixed
+    #pro getLog as String
+    #   get
+    #       return __log
+        
+class EPoint
+    def main is shared
+        assert MClass.xx == 'foo magoo.'
+        assert MClass.getLog.trimEnd.startsWith('static initializer called')
+        assert MClass.getLog.trimEnd.endsWith('foo magoo.')
+        

Tests/120-classes/250-shared-classes/100-static-class.cobra

@@ +1 @@
+# shared on class names, all memebers implicitly also shared
+class MClass is shared
+    var log = ''
+        #is protected
+    
+    cue init
+        .addLog('static initializer called.')   
+        
+    def xx as String
+        v ='foo magoo.'
+        .addLog(v) 
+        return v
+
+    def addLog(s as String)
+        .log += s 
+        .log += '\n'
+        
+    #get getLog from mlog   # backing variable must be _ prefixed
+    #pro getLog from mlog   # backing variable must be _ prefixed
+    pro getLog as String
+        get
+            return .log
+        
+class EPoint
+    def main is shared
+        assert MClass.xx == 'foo magoo.'
+        assert MClass.getLog.trimEnd.startsWith('static initializer called')
+        assert MClass.getLog.trimEnd.endsWith('foo magoo.')
+