Ticket #181: ert-cleanup-intfiles.patch

Source/Compiler.cobra

@@ -887 +887 @@
     def _exitFromErrors
         require .errors.count
         .printMessages
+        _deleteIntermediateFiles
         throw StopCompilation(this)
 
     def printMessages

Tests/700-command-line/871-ert.cobra

@@ +1 @@
+# .skip.
+# compiled by 870-ert-intfiles and is expected to fail compilation
+class X
+    var y=z
+    def main is shared
+        pass

Tests/700-command-line/870-ert-intfiles.cobra

@@ +1 @@
+# check that a failed compile with -ert doesnt leave any additional 
+# Native_ert* files behind. ticket:181
+class Wert
+    def main is shared 
+        file = '871-ert'
+        src  = '[file].cobra'
+        exe  = '[file].exe'
+        
+        cobraPath = CobraCore.findCobraExe to !
+        p as System.Diagnostics.Process?
+        # chk no files 'Native_ert*.cs' in cwd
+        ertCount = .getNativeIntermediateFiles.count
+        assert ertCount == 0
+        output = CobraCore.runCobraExe(cobraPath, '-c -ert [src]', out p)
+        assert 'error: Cannot find "z".' in output
+        assert p.exitCode <> 0 and not File.exists(exe)
+        assert .getNativeIntermediateFiles.count == ertCount
+    
+    def getNativeIntermediateFiles as IList<of String> is shared
+        allfiles = Directory.getFiles('.')
+        ertfiles = for f in allfiles where f.startsWith(r'.\Native_ert') get f[2:]
+        return ertfiles

Developer/IntermediateReleaseNotes.text

@@ -392 +392 @@
 * Fixed: Cobra gives an inscrutable error message for numeric for-loops that have incompatible numeric types. ticket:165
 
 * Fixed: Improper codegen for static constructors. ticket:169
+
+* Fixed: Non removal of Intermediate file if -ert specified and compilation fails. ticket:181