Ticket #184: access-lc-namespace.patch

Source/TypeProxies.cobra

@@ -390 +390 @@
         """
         # don't need to check "basic types" like int, bool, etc. here. the parser does those.
         if name.isCapitalized
-            symbol = .compiler.symbolForName(name, true, false)  # nested enum and class types are capitalized and can be members of the current class
+            symbol = .compiler.symbolForName(name, false)  # nested enum and class types are capitalized and can be members of the current class
+        else if name == name.toLower # all lowercase
+            symbol = .compiler.symbolForName(name, false, true)
         else
             symbol = nil
         if symbol is nil
@@ -399 +401 @@
                 if not name.isCapitalized
                     # not very sophisticated, but catches 'string', 'object', etc.
                     name = name.capitalized
-                    symbol = .compiler.symbolForName(name, true, false)
+                    symbol = .compiler.symbolForName(name, false)
                     if symbol is not nil
                         if '<' in name  # handle generics
                             # 'dictionary<of ' vs. 'Dictionary<of,>'
@@ -409 +411 @@
             if symbol is nil
                 sugg = Compiler.suggestionFor(name) ? ''
                 if sugg == '' and not name.isCapitalized
-                    other = .compiler.symbolForName(name.capitalized, true, false)
+                    other = .compiler.symbolForName(name.capitalized, false)
                     if other, sugg = name.capitalized
                 if sugg <> '', sugg = ' Try "[sugg]". Also, consider the -correct-source option (see cobra -h for details).'
                 .throwError('Cannot find type for "[_name]".[sugg]')

Source/Expr.cobra

@@ -832 +832 @@
     def _bindImp
         base._bindImp
         if not _definition
-            possible = .compiler.symbolForName(.name, true, false)
+            possible = .compiler.symbolForName(.name, false)
             if not possible
                 .throwError('Cannot locate enumeration type "[.name]".')
             else if possible inherits EnumDecl
@@ -1002 +1002 @@
             canBeUndottedMember = _name.canBeUndottedMemberName
             if canBeUndottedMember
                 # assert .compiler.boxStack.count TODO: identifier expr is being used by PostCallExpr which is used for attribute calls
-                _definition = .compiler.symbolForName(_name, canBeUndottedMember, false)
+                _definition = .compiler.symbolForName(_name, false)
             else
                 # local var ref: foo
                 if .compiler.codeMemberStack.count  # could be: var _x = y   or: has foo
                     _definition = .compiler.findLocal(_name)
                 if _definition is nil
-                    _definition  = .compiler.symbolForName(_name, false, false, true)  # 3rd party DLLs have lowercase class names like iConnection
+                    _definition  = .compiler.symbolForName(_name, false, true)  # 3rd party DLLs have lowercase class names like iConnection
             if _definition is nil and not canBeUndottedMember
                 if _superNode inherits BinaryOpExpr
                     if _superNode.right is this
@@ -1615 +1615 @@
         expr = .expr
 
         if expr inherits IdentifierExpr
-            if expr.name.startsWith('_') and not .compiler.symbolForName(expr.name, true, false) inherits BoxVar
+            if expr.name.startsWith('_') and not .compiler.symbolForName(expr.name, false) inherits BoxVar
                 # method invocation
                 # _foo(x) --> ._foo(x)
                 newCall = CallExpr(.token, .name, .args, true)
@@ -1777 +1777 @@
     def _handleClassInitializer
         initCall as Initializer?
         if .args.count > 0
-            theClass = .compiler.symbolForName(.name, true, false, true) to ClassOrStruct?
+            theClass = .compiler.symbolForName(.name, false, true) to ClassOrStruct?
             if theClass is not nil
                 possibleCalls = theClass.memberForName("cue.init")
                 if possibleCalls is nil

Source/Statements.cobra

@@ -60 +60 @@
             usingExistingLocal = false
             if canBeUndottedMember
                 assert .compiler.boxStack.count
-                definition = .compiler.symbolForName(ve.name, canBeUndottedMember, false) to passthrough
+                definition = .compiler.symbolForName(ve.name, false) to passthrough
                 if definition is nil
                     ve.throwUnknownIdError
             else

Source/Compiler.cobra

@@ -832 +832 @@
                     _basicTypes.add(.intType(signed, size))
         return _basicTypes to !
 
-    def symbolForName(name as String, canBeMember as bool, haveThis as bool) as IMember?
-        return .symbolForName(name, canBeMember, haveThis, false)
+    def symbolForName(name as String, haveThis as bool) as IMember?
+        return .symbolForName(name, haveThis, false)
 
-    def symbolForName(name as String, canBeMember as bool, haveThis as bool, isLowerOkay as bool) as IMember?
+    def symbolForName(name as String, haveThis as bool, isLowerOkay as bool) as IMember?
         """
         name - obvious.
-        canBeMember - the symbol can be a member of the current box
-            TODO: can this be retired now that there is findLocal?
         haveThis - if false, symbols like methods, properties, etc. will not be returned while enums, nested classes, etc. could be.
+        isLowerOkay - true if a lowercase name (non capCased) is allowed.   
         """
         require
             name.length
@@ -856 +855 @@
 
             # check the current box which will ask its namespace which will ask its `use` directives
             if _boxStack.count
-                #print '>> .compiler.symbolForName([name], [canBeMember], [haveThis])'
+                #print '>> .compiler.symbolForName([name], [haveThis])'
                 if not isLowerOkay and name[0].isLower
                     assert false, 'use findLocal instead. [name]'
                     return nil

Source/Node.cobra

@@ -1146 +1146 @@
     
     def findLocal(name as String) as AbstractLocalVar?
     def suggestionForUnknown(word as String) as String?
-    def symbolForName(name as String, canBeMember as bool, haveThis as bool) as IMember?
-    def symbolForName(name as String, canBeMember as bool, haveThis as bool, isLowerOkay as bool) as IMember?
+    def symbolForName(name as String, haveThis as bool) as IMember?
+    def symbolForName(name as String, haveThis as bool, isLowerOkay as bool) as IMember?
 
 
     ## Current objects

Source/Attributes.cobra

@@ -56 +56 @@
                 .throwError('Expecting an attribute class instead of a [defi.englishName].')
         else if _expr inherits PostCallExpr
             name = _expr.name
-            if not name.endsWith('Attribute') and name.canBeUndottedMemberName and not .compiler.symbolForName(name, true, false)
-                if .compiler.symbolForName(name+'Attribute', true, false)
+            if not name.endsWith('Attribute') and name.canBeUndottedMemberName and not .compiler.symbolForName(name, false)
+                if .compiler.symbolForName(name+'Attribute', false)
                     _expr = PostCallExpr(_expr.token, IdentifierExpr(_expr.token, name+'Attribute'), _expr.args, isForAttribute=true)
             else
                 _expr.isForAttribute = true

Tests/720-libraries/400-other/lcase.cs

@@ +1 @@
+/*
+lcase namespace in  lib test - Library
+cobra -t:lib lcase.cs
+gmcs -t:library -out:lcase.dll lcase.cs
+csc /t:library /out:lcase.dll lcase.cs
+*/
+namespace lcase {
+   public class A {
+      string _what = "class A";
+      
+      public int One = 1;
+
+      public string what {
+        get { return _what; }
+        set { _what = value;}
+      }
+      public string getWho() {
+        return "lc";
+      }
+   }
+}

Tests/720-libraries/400-other/109-compile-lcase.cobra

@@ +1 @@
+# compile lowercase lib lcase.cs
+class CobC
+    def main is shared
+    
+        output = .runCobraExe('-t:lib lcase.cs')
+        try
+            assert 'Compilation succeeded' in output
+            assert File.exists('lcase.dll') 
+        success
+            print 'lcase.cs compile'
+        
+    def runCobraExe(args as String) as String is shared
+        p as System.Diagnostics.Process?
+        return CobraCore.runCobraExe(args, out p)
+        

Tests/720-libraries/400-other/110-access-lc-namespace.cobra

@@ +1 @@
+# .args. -reference:./lcase
+# Test access to classes/Types in a lowercase named namespace
+# numbered lines were errors pre ticket:184 fix
+use lcase 
+
+class Asub inherits lcase.A    # /1 cannot find type for lcase.A
+
+    def main
+        a = lcase.A()
+        assert a.one == 1
+        a = A()
+        assert a.one == 1
+    
+        aa as lcase.A = lcase.A()  # /3 cannot find type for lcase.A
+        assert aa.one == 1
+        .x(aa)
+    
+        assert aa.getWho == 'lc'
+        assert aa.what == 'class A'
+        aa.what = 'Ksrsly'
+        assert a.what == 'class A'
+        assert aa.what == 'Ksrsly'
+        
+    def x(a as lcase.A)     # /2 cannot find type for lcase.A
+        assert a.one == 1
+    

Developer/IntermediateReleaseNotes.text

@@ -404 +404 @@
 * Fixed: Numeric for expression broken for `get` expressions with types other than `int`  ticket:158
 
 * Fixed: Operators `?` and `?=` give error if left hand expression is not nilable.  ticket:117
+
+* Fixed: Better handling of access to items in lowercased namespaces (libs) : ticket:184
+