Ticket #251: static-init-nil-chk.patch

Source/Members.cobra

@@ -1197 +1197 @@
                 for decl in .parentBox.declsInOrder
                     if decl inherits BoxVar
                         assert decl.type
-                        if not decl.type inherits NilableType and decl.type.isReference and not decl.isShared
+                        if not decl.type inherits NilableType and decl.type.isReference and .isShared == decl.isShared
                             if decl.name.startsWith('_')
                                 expr = IdentifierExpr(token, decl) to Expr
                             else

Tests/400-misc-bugs/260-static-init-nil-check.cobra

@@ +1 @@
+# bug with erroneous null check on non shared var in static init
+class A
+
+    var isntShared as String
+
+    cue init
+        base.init
+        .isntShared = '1'
+
+    shared
+
+        var isShared as String
+
+        cue init
+            .isShared = '2'
+            # failed here (inserted null checking)
+class P
+
+    def main is shared
+        assert A().isntShared == '1'
+        assert A.isShared     == '2'