Ticket #254: all-empty-true.patch

Source/Cobra.Lang/Native.cs

@@ -269 +269 @@
     }
 
     static public bool All<T>(IEnumerable<T> items) {
+        int counter = 0;
         foreach (T item in items)
+                {
+                        counter++;
             if (!IsTrue(item))
                 return false;
+        }       
+        if (counter == 0)
+            return false;
         return true;
     }
 
     static public bool All(IEnumerable items) {
+        int counter = 0;
         foreach (object item in items)
+        {
+                        counter++;
             if (!IsTrue(item))
                 return false;
-        return true;
+        }
+        if (counter == 0)
+            return false;
+                return true;
     }
 
     static public bool Any<T>(IEnumerable<T> items) {

Tests/500-dynamic/104-dynamic-ops.cobra

@@ -212 +212 @@
         assert not all t
         assert not any t
         t.clear
-        assert all t
+        assert not all t # change for tkt:254
         assert not any t
 
     def testConcat

Tests/110-basics-two/604-all-any-ops.cobra

@@ -12 +12 @@
         assert not all t
         assert not any t
         t.clear
-        assert all t
+        assert not all t # # chg for tkt:254, all on empty list -> false
         assert not any t
 
         # sets
@@ -26 +26 @@
         assert not all s
         assert not any s
         s.clear
-        assert all s
+        assert not all s # chg for tkt:254, all on empty list -> false
         assert not any s
 
         # complex expressions

Developer/IntermediateReleaseNotes.text

@@ -487 +487 @@
 * Fixed: Some initialization expressions for a `var` or `const` declaration give an internal error.  ticket:222
 
 * Fixed: Using a struct-typed `result` in a method's `ensure` produces a false error message.  ticket:219
+
+* Fixed: all on empty list returns true instead of false.  ticket:254