Ticket #271: generic-method-callchks.patch

Source/Expr.cobra

@@ -784 +784 @@
     def _checkGenerics(definition as BoxMember, type as inout IType?) as BoxMember
         if .genericArgTypes and .genericArgTypes.count
             if definition inherits Method
-                definition = definition.constructedMethodWith(.genericArgTypes to !)
-                type = definition.resultType
+                if not definition.isGenericDef
+                    .recordError('Method "[definition.name]" is being invoked as a generic but it is not declared as a generic method.') 
+                else if .genericArgTypes.count <> definition.genericParams.count
+                    .recordError('Generic method "[definition.name]" has a mismatch on the number of generic arg types. It is being called with [.genericArgTypes.count] but is declared with [definition.genericParams.count].') 
+                else
+                    definition = definition.constructedMethodWith(.genericArgTypes to !)
+                    type = definition.resultType
             else
                 .throwError('Cannot pass type arguments to "[definition.name]" because it is a [definition.getType.name].') # @@ _definition.englishName; also might need this error in other locations
         return definition

Tests/240-generics/400-generic-methods/212-types-count-err.cobra

@@ +1 @@
+class GenErr
+    # 2 arg types generic
+    def calc<of T, T1>(param as T) as T1 is shared
+        return param  
+        
+    def main is shared  
+        # calling with one arg type
+        res = .calc<of int>(1) # .error. 
+        CobraCore.noOp(res)

Tests/240-generics/400-generic-methods/210-call-to-nongeneric-err.cobra

@@ +1 @@
+class GenErr
+    # this is not a generic method
+    def calc(param as int) as int 
+        return param  % 2 
+        
+    def main 
+        # this is calling it like it is
+        res = .calc<of int>(1) # .error. invoked as a generic but it is not declared as a generic
+        CobraCore.noOp(res)