Ticket #337: no-of-trap.patch

Source/CobraParser.cobra

@@ -2926 +2926 @@
                         else
                             sugg = ''
                         .throwError(ErrorMessages.syntaxErrorAfterDot + sugg)
+                    # trap '< TYPE,' and '<TYPE>' as malformed generic specs
+                    if op == 'LT' and left inherits DotExpr and right inherits TypeExpr 
+                        sugg = 'If you are calling a generic that syntax should be "<of [right.token.text]..."'
+                        .throwError('Invalid comparison to a Type. [sugg]')
+                    if left inherits CompareExpr
+                        if left.op=='LT' and op == 'GT' and left.left inherits DotExpr and left.right inherits IdentifierExpr 
+                            if ((left.left to DotExpr).right inherits MemberExpr) and (left.right to IdentifierExpr).name.isCapitalized 
+                                sugg = 'If you are calling a generic that syntax should be "<of [left.right.token.text]..."'
+                                .recordError('Invalid comparison to a Type. [sugg]')
                     if op.length, left = BinaryOpExpr.make(opToken, op to !, left to !, right)
             finally
                 .opStack.pop

Tests/820-errors/200-expressions/800-generics/bad-generic-builtin-type.cobra

@@ +1 @@
+class Program
+
+    def main
+        #.method<int>(14)
+        x= .m1<int>(14) #.error. calling a generic
+        CobraCore.noOp(x)
+        
+    def m1<of T> as Type
+        return String
+

Tests/820-errors/200-expressions/800-generics/bad-generic-any-type.cobra

@@ +1 @@
+class Program
+
+    def main
+        #.m1(14)
+        #.method<of int>(i)
+#       x= .m1<int>(14)
+        x = .m1<String>(14)    #.error. Invalid comparison to a Type
+        x1 = .m1<Program>(15)  #.error. should be "<of Program
+        x2 = .m1<AnyTypeName>(99)  #.error. should be "<of AnyTypeName
+        
+        x3 = .m2(14)<Program>(20) # this shld not err given above errors
+        
+        CobraCore.noOp(x, x1, x2, x3)
+        
+        val = 44
+        assert .m3<val>(50)
+        
+    def m1<of T> as Type
+        return String
+
+    def m2(a as int) as Type
+        return String
+        
+    def m3 as int
+        return 33
+        

Tests/820-errors/200-expressions/800-generics/bad-generic-call-expr.cobra

@@ +1 @@
+class Program
+
+    def main
+        x1= .m2(14)<Program>(14) # .error. cannot be compared
+        CobraCore.noOp(x1)
+        
+    def m2(a as int) as Type
+        return String

Tests/820-errors/200-expressions/800-generics/bad-generic-multiple.cobra

@@ +1 @@
+# .error. general syntax error
+class Program
+
+    def method<of T>(argument as T)
+        print argument
+
+    def main
+        x= .m1<int,int> (14) #.error. Invalid comparison to a Type 
+                                    #.error general syntax error
+        CobraCore.noOp(x)
+        
+    def m1<of T, T1> as Type
+        return String
+