Ticket #34: var-isnames-assign.patch

Source/CobraParser.cobra

@@ -1104 +1104 @@
             .throwError('Class variables must start with lowercase letters (after the underscore(s)) to distinguish them from other types of identifiers.[sugg]')
         type = if(.optional('AS'), .typeId, nil) to ITypeProxy?
         if .optional('ASSIGN')
+            oldState = .opPrecSuppress( 'IS', 'ISNOT')
             initExpr = .expression to ?
+            .opPrecRestore(oldState)
         else
             initExpr = nil
             if type is nil
@@ -2385 +2387 @@
             'OLD':   _binaryOpPrec['STARSTAR']+1,
         }
 
+    # suppress named entries in op precedence table
+    def opPrecSuppress( ops as vari String) as IDictionary<of String, int> is shared
+        require ops.length >0
+        ensure oldState.count == ops.length
+        oldState = Dictionary<of String, int>()
+        for op in ops
+            oldState[op] = _binaryOpPrec[op]
+            _binaryOpPrec[op] = -1      
+        return oldState
+            
+    # restore to values before suppressed
+    def opPrecRestore( prev as IDictionary<of String, int>) is shared
+        require prev.count >0
+        for op in prev.keys
+            _binaryOpPrec[op] = prev[op]
+        
     var _inExpression as int
     
     def expression as Expr

Tests/120-classes/220-fields-assign-isnames.cobra

@@ +1 @@
+class Point
+
+    var x as int  # no underscore
+    var y as int
+    var s as String = '' is public # a non-nil reference type assigned at decl
+
+    def init
+        assert .s == ''
+        .s = 'x'
+
+    get sum as int
+        return .x + .y
+
+class Program
+
+    def main is shared
+        p = Point()
+        assert p.s =='x'
+        p.x = 2
+        p.y = 3
+        assert p.x + p.y == 5
+        assert p.sum == 5

Developer/IntermediateReleaseNotes.text

@@ -53 +53 @@
 * Fixed: Method return types from generics in DLLs are always considered nilable even if the generic parameter was not (such as `bool`). ticket:22
 
 * Fixed: Assignments (and other side effects) can appear in assert conditions even though they might be excluded during compilation or run-time. ticket:4 (hopscc)
+
+* Fixed: compile error if attempt declare a class var with both isnames setting and assignment (hopscc)