Wiki

Ticket #156 (closed defect: fixed)

Opened 16 years ago

Last modified 16 years ago

install-from-workspace behaves badly if C:\Cobra cannot be created

Reported by: Caligari Owned by: Chuck
Priority: medium Milestone:
Component: Cobra Compiler Version: 0.8.0
Keywords: install-from-workspace Cc:

Description

The installation directory is currently hard-coded into install-from-workspace.cobra, and when it cannot be created the install process stops with an assert.

1. we should not assert when the install directory cannot be created.

2. we should check the installation directory before doing a lot of work.

3. we should make it possible for the user to override the given installation directory.

Attachments

InstallPath.patch Download (7.8 KB) - added by Caligari 16 years ago.
Patch to install-from-workspace

Change History

Changed 16 years ago by Caligari

Patch to install-from-workspace

Changed 16 years ago by Caligari

  • owner changed from Caligari to Chuck
  • status changed from new to assigned

Created a new first stage, responsible for working out the install directory and verifying that it exists (by creating it, if needed).

Improved behavior of requireDir when the directory cannot be created - catches the exception, reports the error (also suggests overriding the install directory, which might not be appropriate generally, but should be okay in this app).

Added concept of option file "installDirectory" which can be created by the user in Source. The first line should contain the directory in which to install Cobra. The file could be provided in the repository, to be edited by users who need to change it (and perhaps with documentation on the second and following lines), but it is not provided here, as it would differ for *nix and Windows.

Added requirement to copyFilesToInstallDirectory to ensure the install directory is present.

Changed 16 years ago by Chuck

  • status changed from assigned to closed
  • resolution set to fixed

Done in changeset:2035

I changed the config filename to 'install-directory.text'

I made some edits to both new code and old code, so you may need to rm/del and "svn up" your InstallFromWorkspace.cobra.

Note: See TracTickets for help on using tickets.