Missing inout gets C# error message rather than Cobra error message.

[torial]

If a call to a fxn that has inout parameters is made w/o the inout parameter, the C# equivalent message is given: "error: Argument "1" must be passed with the "ref" keyword" However, adding "ref" before argument 1 does not fix the issue, adding "inout" does.

%% args -ref:System.Xml -ref:System.Drawing

use System.Windows.Forms #from "System.Windows.Forms"
use System.Xml #from "System.Xml"
use System.Text.RegularExpressions
use System.Drawing

class WordMatcher inherits Form
    
    cue init
        base.init
        .text = 'TMX Word Match Finder'
        .width = 800
        .height = 600
        
        list = List<of int>()
        .getList(list) #error: Argument "1" must be passed with the "ref" keyword
        .getList(inout list) #this compiles fine if above line is commented out.
    
    
    def getList(list as inout List<of int>)
        trace list

class Program

    def main is shared
        has STAThread
        Application.run(WordMatcher())

[Chuck]

Nice catch. Here is a smaller program that demonstrates the bug:

class P

	def foo(x as inout int)
		x = 5

	def main
		y = 0
		.foo(y)
		assert y == 5

[Chuck]

I have added a little more "cleanup" in SharpCompilationMessage.cobra that at least improves how this reads. changeset:2296

That does not fix this ticket as the error check should still be done in Cobra, but it helps.

[hopscc]

Fix for non checking of inout label/param mismatches.
patch + test + relnote.

[Chuck]

Applied in changeset:2360. Thanks.