Wiki

Ticket #58 (closed enhancement: fixed)

Opened 15 years ago

Last modified 15 years ago

Code only refactoring

Reported by: hopscc Owned by:
Priority: medium Milestone:
Component: Cobra Compiler Version: 0.8.0
Keywords: Cc:

Description

Ticket for patches for refactoring changes that dont affect functionality.

Attachments

expr-refactor.patch Download (26.6 KB) - added by hopscc 15 years ago.

Change History

Changed 15 years ago by hopscc

Changed 15 years ago by hopscc

Patch to refactor excessively long and complicated Expr.cobra _bindImp methods down to more reasonable sizes. Pull out and rename submethods by their function (so far as I could determine it). Remove duplicate and dead code

Correct warning generated by running current compiler code on itself

Add new warning code to give indication of excessively long methods
( currently enabled - should probably be modified to be turned off by default and eventually allow user specification)

Changed 15 years ago by Chuck

  • status changed from new to closed
  • resolution set to fixed

Applied in changeset:1736

Nice job.

There are some minor tweaks, but not as many as usual.
Btw this was the first patch where I found "def[TAB]foo" which was visible when viewing the patch through Trac. Not sure where that's coming from, but let's stick with "def foo".

Thanks.

Note: See TracTickets for help on using tickets.
User Testimonial
"I'm really getting the hang of testing Cobra-style.
 I feel more productive (and willing to write tests)."
   – Todd Alexander

© 2003 - 2012 Cobra Language LLC. All rights reserved.